Nico De Cleyre comments

Results 103 comments of


                                            Nico De Cleyre

Refactor BaseCommand for `flow export`

Can I work on this?

Refactor BaseCommand for `flow export`

Tested it, it doesn't lead to breaking changes 😉

New sample script: make a list or library read-only for all users

Can I work on this 🧹

New command: Create crawled properties for SharePoint online using CLI

What is the context of this issue? As far as I know, you cannot create a crawled property since these get automatically created by the index? 🤔

Using util functions in favor of commands calling other commands to reuse code

It would be nice if we could get rid of commands calling other commands. Could I start working on some of these?

Using util functions in favor of commands calling other commands to reuse code

> Of course you can! Be sure when you create an issue for them to mention this epic, that way the issue will be linked. Also, to quickly create an...

Using util functions in favor of commands calling other commands to reuse code

Very good, I would like to suggest one more suggestion, the description of the parameters: ```TypeScript /** * Gets app catalog from tenant * returns undefined if none is configured...

Using util functions in favor of commands calling other commands to reuse code

> That's okay as well. As long as we describe the necessary util(s) up front. Alright, here is an overview: | Command | The command to refactor | Util function...

Using util functions in favor of commands calling other commands to reuse code

For the sake of completeness, the following 2 commands have already been refactored to util functions, so they may be removed from the list of this epic: - [ ]...

Using util functions in favor of commands calling other commands to reuse code

That's ok for me. Thank you @martinlingstuyl!