Nathan
Nathan
@undernorthernsky thank you for the investigation. Actually, it makes a lot of sense because of this line: https://github.com/nathhB/nbnet/blob/master/nbnet.h#L3617 Trying to destroy anything after destroying the memory manager will obviously raise...
This commit fixes the segfault: https://github.com/nathhB/nbnet/commit/7ef4d42cd32e6f45c6b991a4d50a7b7e3b4b0cb0 I'll close the issue when the memory leaks are fixed.
I'll take a look in the future. Also, it should not be too hard to add support for it, so you can probably implement it yourself and create a PR....
@iWas-Coder I'm glad you are enjoying nbnet. Thank you very much for this MR. It looks good but for some reason the CI did not run. I'll need to see...
@stemvork the problem was indeed not related to your changes, it was an issue with emscripten version which I fixed in this commit: https://github.com/nathhB/nbnet/commit/a33a169f41606b4bb2090b8340643628e382d65b regarding the PR, the change looks...
@raisinrand thank you for the MR. Could you explain in more detail what this achieves exactly? There is also a TODO left in the code, not sure if that's intentional....