nbnet icon indicating copy to clipboard operation
nbnet copied to clipboard

Solved: NBN_GameClient_Start does not support domain name #28

Open stemvork opened this issue 1 year ago • 2 comments

In NBN_GameClient_StartEx(...) we check if the host == "localhost" and use "127.0.0.1" instead. Also, updated the echo example to use host "localhost" to test this change. Everything seems to be working.

stemvork avatar Aug 24 '24 06:08 stemvork

Interesting, that most tests succeed but 3 fail. I do not see how failing the emcc or webrtc soak tests is related to the code changed and could use some guidance on how to succesfully fix the issue.

stemvork avatar Aug 24 '24 20:08 stemvork

@stemvork the problem was indeed not related to your changes, it was an issue with emscripten version which I fixed in this commit: https://github.com/nathhB/nbnet/commit/a33a169f41606b4bb2090b8340643628e382d65b

regarding the PR, the change looks OK for resolving localhost but the idea behind the original issue was to resolve any domain name.

nathhB avatar Sep 12 '24 10:09 nathhB