Max Howell
Max Howell
I guess we would merge for v6 since v7 is now mainline and we don‘t intend to maintain v6 beyond fixes. Ideally would be a little less intense though…
People have asked this before (being able to change the default queue for a specific chain) and my argument generally was you return promises all over the place, and in...
We should be able to drop the API surface with a refactor or two. I'm not fussed about backwards compatibility, since PMKv6 is stable and will be maintained, I feel...
I removed this test for now even after trying a bit to get it to work.
Not seen this before. `seal` does not call itself and is constructed so it should not call any handlers (eg. then handlers) until the “seal” is finalized, and subsequence `seal`...
The code is here for this area: https://github.com/mxcl/PromiseKit/blob/master/Sources/Box.swift#L36-L57 Hard to see how it could recurse, the `barrier` synchronization prevents re-entry and sets the state of the `Box` to `sealed` so...
Our cancel code *is* a bit of ObjC trickery that potentially is a bug in Swift. Only way we can fix this. is with a testcase unfortunately, anyone vested enough...
I just re-examined the code in question and genuinely cannot see a valid concurrency issue that would indicate this is PromiseKit’s fault. The data structures are all manipulated atomically, even...
At this point one of you people needs to step up, report the bug, give the Swift team a test case and see what they say, there is no point...
k, I figured it out, it’s a stackoverflow. Here’s an example of it happening with Swift NIO: https://github.com/apple/swift-nio/issues/970 It only happens for situations where you are chaining promises > ~4,000...