Max Howell

Results 625 comments of Max Howell

Exactly? I have no idea. If something more vague will do, then look for the documentation that tells you how to refer to a git tag from GitHub. If that...

Documented: https://github.com/mxcl/PromiseKit/blob/v6/Documentation/CommonPatterns.md#cancellation Documented: https://github.com/mxcl/PromiseKit/blob/v6/Sources/Catchable.swift#L18

v7 docs seem to have both made cancelization incredibly complex and also made the docs unreadable. So, yeah this could be improved. Sadly I don't really understand how cancellation works...

> Example below. To me, it was very surprising that neither the .done nor the .catch block were called Cancelation is neither success nor failure. Hence this behavior. Instead use...

Yeah we really should print a debug message, this catches people, no pun intended.

Then use Carthage with v6 presumably. It will build xcframeworks.

Rebase for new CI infrastructure

This is very intrusive. I cannot merge.

We need to run the full CI against this. I'll make that possible with a comment or something.