Max Howell

Results 625 comments of Max Howell

Great thanks x. When I said callback only called once I meant it’s called like 50 times, but I expected 50, after that the notifications keep getting resent until I...

The recent commit fixes this, though an awful lot of notifications seem to get dropped instead, with a lot of internalServerError errors and `~HTTP2Client.startReadThread` messages. So thanks, I'll look into...

Actually maybe not 100% fixed, looking at my notifications log some were doubled up. But it does stop now at least rather than sending them until I kill the server.

Yeah ok, this seems to possibly be the issue, I put a print counter into the code when HTTP2 streams are created and when I use my test case I...

I'm pretty experienced with doing Swift on Linux on Travis, so ask if you need help. I'm not familiar with Circle though. Edit: sorry, old ticket; offer still stands though.

I will PR, any particular way you want this done? It could be different functions, it could be an enum parameter, boolean parameter. Or I can just choose.

“I know, I’ll install the GitHub slack app so I can get notifications for my team’s activity on GitHub” *is overwhelmed by his own activity* > mxcl uninstalls the app....

This didn't work for my GitX installation since it runs in the ObjectiveGit.framework build and at that point there is no bundle to copy the dylibs to.