Mateusz Warzyński

Results 41 comments of Mateusz Warzyński

I updated the PR to follow the style guide and attached debug logs (with Valgrind). I also created a separate PR with the documentation for this feature (https://github.com/fluent/fluent-bit-docs/pull/897). In my...

@PettitWesley Thank your for the comprehensive code review. I am ready for the second round. :rocket:

I've made an attempt to write tests for this feature: https://github.com/mwarzynski/fluent-bit/pull/1 1. It uses Python3 to mock the HTTP server (not sure if it's okay to add this dependency /...

@matthewfala Would you be willing to provide a guidance how I should approach using the mentioned mock api for the aws filter tests? (Can I really _use_ the mock api...

Also, it would be nice if someone could confirm (through manual testing) that this functionality actually works on their EC2s. Although I've tested it a dozen times, there may be...

> 1. filter_aws: move out the http requests related code to module, just call the constructor flb_aws_ec2_metadata This one is actually easier than I thought, because there is a "duplicated"...

@matthewfala I have a work in progress branch for adding the unit tests with the http server mock in C: https://github.com/mwarzynski/fluent-bit/pull/2. Feel free to take a look and share your...

If we would enable all options for the AWS Filter, here is http server which allows to run & check the filter locally (not inside the EC2): ```python #!/usr/bin/env python3...

Do you know what I need to do in order to satisfy the documentation requirement? Why is the `docs-required` still there?

> Before merge, this should be two commits probably. One for all aws filter code changes, and one for the testing changes. @PettitWesley I will rebase on latest master and...