Mateusz Warzyński
Mateusz Warzyński
I have two Valgrind complaints in the current version. ``` ==35884== Thread 2 flb-pipeline: ==35884== Conditional jump or move depends on uninitialised value(s) ==35884== at 0x483BC98: strlen (vg_replace_strmem.c:459) ==35884== by...
> I understand it will make the PR big, but its best to have the new feature and tests all in the same PR. I agree, ideally I would really...
> we must have BOTH the implementation fully completed and tested in the real world AND unit tests that can pass CI Out of curiosity, so why the Filter AWS...
I pushed the "new" version which uses flb_aws_imds http client and contains unit tests. It's still work in progress, because unit tests are not finished yet. Filter AWS functionality should...
I've pushed a fix for memory leaks in the unit tests for `filter_aws`. (I am not a fan of adding coupling in the `aws.c` code to the `filter_aws` tests, but...
@PettitWesley Would you please check out my PR once again?
@PettitWesley @matthewfala Would you please help me with fixing the memory leaks in unit tests? What am I doing wrong? --- EDIT: Okay, I think I've figured it out. ```c...
> Can you please squash this to a single or a few commits as we are getting closer to merge? Yes, of course. I will do it today. > I...
@PettitWesley I think I fixed the issue (one-line added, see the comment). I also squashed all the commits to just 1.
PR which adds support for EC2 tags to the AWS Filter: https://github.com/fluent/fluent-bit/pull/6065