Matt White comments

Results 18 comments of


                                            Matt White

sql: add tracing for locks requested by a scan

> nit: what's reason for incrementing `bytesHint` by 1? I must've typoed that while updating the print statement. I was sitting here wondering "why 1025? that's a weird size."

sql: add tracing for locks requested by a scan

bors r+

Support INSERT & UPDATE of implicit regional by row partitioning under READ COMMITTED isolation

@rytaft @mgartner I added a test for implicit partitioning, but not for sharded indexes. It turns out that those already worked, so I just deleted the logic around them in...

Support INSERT & UPDATE of implicit regional by row partitioning under READ COMMITTED isolation

RFAL

Support INSERT & UPDATE of implicit regional by row partitioning under READ COMMITTED isolation

bors r+

sql, kv: support explicit unique checks under non-serializable isolations for INSERT & UPDATE

Breaking this into multiple parts for added visibility. This is about INSERT & UPDATE. I'll open a new issue to track UPSERT and ON CONFLICT, both of which make use...

fix pulling full vectors from the primary key when column families are in use

Okay, I'll wait for @DrewKimball to look at the span.Builder & span.Splitter stuff.

fix pulling full vectors from the primary key when column families are in use

RFAL

fix pulling full vectors from the primary key when column families are in use

I'm not sure I follow your last question. I think the only real problem left here is the prefix column doesn't match PK column direction, which I'm working on. My...

fix pulling full vectors from the primary key when column families are in use

I'm really not excited to introduce another SpanBuilder-like thing that isn't SpanBuilder, so I do want to rely upon having the encoded datums cached. I guess it would make sense...