cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

sql: add tracing for locks requested by a scan

Open mw5h opened this issue 1 year ago • 4 comments

Previously, we would only log the spans requested by a scan. To provide additional visibility about lock acquisition, we now include information about locking modes requested by a scan.

Fixes: #115016

Release note: None

mw5h avatar May 23 '24 21:05 mw5h

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 23 '24 21:05 blathers-crl[bot]

CLA assistant check
All committers have signed the CLA.

cockroach-teamcity avatar May 23 '24 21:05 cockroach-teamcity

This change is Reviewable

cockroach-teamcity avatar May 23 '24 21:05 cockroach-teamcity

nit: what's reason for incrementing bytesHint by 1?

I must've typoed that while updating the print statement. I was sitting here wondering "why 1025? that's a weird size."

mw5h avatar May 24 '24 19:05 mw5h

bors r+

mw5h avatar May 24 '24 22:05 mw5h