David Nagy comments

Repositories
Issues
Comments

Results 3 comments of


                                            David Nagy

Should not throw TypeError when saving `null` for a field with subproperty index-exclusion

@danieljbruce PR is open with the suggested change.

feat: make object key types always extend string

Most of my comments were addressed 🙏 except for the one related to `_objectEntries`. Since the PR touched the typings there, I think a type-unit-test would be nice there too.

feat: Adding RequireProp type helper

Not seeing how this would be used, I say LGTM, but in my experience Kirill has opinions on being too precise with types, so I'll defer to him. If it's...