js-lib icon indicating copy to clipboard operation
js-lib copied to clipboard

feat: make object key types always extend string

Open frodi-karlsson opened this issue 4 months ago • 2 comments

I understand the test may be useless 😅 If the types are reverted, it will fail at tsc with a type error though

frodi-karlsson avatar Oct 15 '25 12:10 frodi-karlsson

Most of my comments were addressed 🙏 except for the one related to _objectEntries.

Since the PR touched the typings there, I think a type-unit-test would be nice there too.

mrnagydavid avatar Oct 20 '25 08:10 mrnagydavid

Oh, sorry 🙏

frodi-karlsson avatar Oct 20 '25 08:10 frodi-karlsson

:tada: This PR is included in version @naturalcycles/js-lib-v15.49.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Nov 27 '25 07:11 github-actions[bot]