Michael Glavassevich

icon indicating a website link http://www.ibm.com icon indicating an email [email protected]

icon company IBM icon location Canada icon location I am the PMC chair for Apache Xerces. I have over twenty years of experience developing components in open source.

Results 10 comments of Michael Glavassevich

runIde: open terminal in IntelliJ 2024.1 EAP leads to IDE crash

I think we're hitting the same issue with our plug-in that opens new terminal windows. Reproduced with the 2024.1 release.

org.eclipse.lsp4jakarta.commons.JavaCursorContextKind.forValue() throws an IllegalArgumentException when passed the value from its own NONE constant.

Since `JavaCursorContextKind` is a copy of an enum class that is also in LSP4MP, LSP4MP also has this issue.

Investigate whether LSP4Jakarta consistently processes fully qualified class names.

A couple more tasks for this item: - [ ] Check for usage of [DiagnosticUtils.getSimpleName()](https://github.com/eclipse/lsp4jakarta/blob/main/jakarta.jdt/org.eclipse.lsp4jakarta.jdt.core/src/main/java/org/eclipse/lsp4jakarta/jdt/internal/DiagnosticUtils.java). Investigate how it's being used to shorten qualified names and determine if that usage is...

Investigate whether LSP4Jakarta consistently processes fully qualified class names.

Should check whether the issues (in Liberty Tools for IntelliJ) with qualified names being tracked here: https://github.com/OpenLiberty/liberty-tools-intellij/issues/879 also apply to this project.

Add unit tests for certain quick fixes

WebSocket - A unit test exists for inserting the `@PathParam` annotation on to method parameters but does not verify all the code actions for all the diagnostics produced by the...

The plugin completes code after typing opening curly brace

@angelozerr I tried this out with our Liberty Tools 24.0.9 release with a recent LSPIJ 0.7.0 build and couldn't reproduce it. We're still on IntelliJ 2024.1.x if that matters.

The plugin completes code after typing opening curly brace

Looks like I reproduced it with the latest LSP4IJ 0.7.0 nightly build. Not sure why I wasn't seeing this before. ![image](https://github.com/user-attachments/assets/3644c6a1-27d4-45c0-bb28-d5e4a29a33e6)

The plugin completes code after typing opening curly brace

> I did a fix in MP LS and it should work now. For your case you should do nothing, just use last LSP4MP (not released yet) and LSP4IJ 0.7.0...

Reduce code duplication in PersistenceMapKeyDiagnosticsParticipant.

Refactoring for the equivalent code in Liberty Tools for IntelliJ was delivered in this PR: https://github.com/OpenLiberty/liberty-tools-intellij/pull/1037.

Explore whether the user experience can be improved for diagnostics / quick fixes involving @Dependent

For reference, see the discussion on this Liberty Tools for IntelliJ PR here: https://github.com/OpenLiberty/liberty-tools-intellij/pull/1091#discussion_r1838585813 which led to this suggestion for improvement.