lsp4jakarta icon indicating copy to clipboard operation
lsp4jakarta copied to clipboard

Investigate whether LSP4Jakarta consistently processes fully qualified class names.

Open mrglavas opened this issue 2 years ago • 2 comments

  • Check whether LSP4Jakarta has the correct behaviour for applications if they specify a fully qualified class name instead of their simple name (e.g. @jakarta.ws.rs.PUT vs @PUT).
  • Check whether LSP4Jakarta unambiguously matches the expected class names when checking diagnostics, applying quick fixes, etc... (e.g. @jakarta.ws.rs.PUT vs @my.random.pkg.PUT).

Note: We're noticing inconsistencies in the processing of qualified names in the code actions / quick fixes in Liberty Tools for IntelliJ and that code was ported from LSP4Jakarta.

mrglavas avatar Jan 04 '24 16:01 mrglavas

A couple more tasks for this item:

  • [ ] Check for usage of DiagnosticUtils.getSimpleName(). Investigate how it's being used to shorten qualified names and determine if that usage is problematic or may become a problem in the future as Jakarta EE evolves.
  • [ ] Review the diagnostic collectors, checking if there are any other methods being used for shortening qualified names.

mrglavas avatar Jan 22 '24 19:01 mrglavas

Should check whether the issues (in Liberty Tools for IntelliJ) with qualified names being tracked here: https://github.com/OpenLiberty/liberty-tools-intellij/issues/879 also apply to this project.

mrglavas avatar Jul 22 '24 17:07 mrglavas