Max Kim

Results 9 issues of Max Kim

Suppose there is a superclass called `MyBaseClass` that doesn't have a Directive/Component meta attached to it. If there is a component class called `MyDerivedClass` which extends `MyBaseClass`, it should be...

Type: bug
P1 high
S1 high
Category: validation

Post-analysis, decide if we want to add ngIgnoreError based on html-tag specification as well as application to being only immediate-next AST. Change current ignoreError based to ngGlobalIgnoreError. Decide after analyzing...

Type: enhancement
State: needs info
P2 medium
S3 low

We take an additional step in converting what is provided by the 'angular_ast' library and converting it into our ast. This is the result of originally not using 'angular_ast' to...

Type: enhancement
P2 medium
Category: refactor

Inline template usage of $event must be preceded by \

Type: enhancement
P2 medium
S1 high
Category: stability/error recovery

This is a pretty big design change - I've decided to essentially remove 'EmbeddedTemplateAst' and 'EmbeddedContentAst'. TL;DR: Having three types had no purpose and just overcomplicated things. Reasoning: - At...

cla: yes

After Pipe expression is implemented, it would be a good point to refactor some of the code to make it cleaner.

Type: enhancement
P2 medium

Not a trivial process; there are changes made within the angular_ast already to define the new Pipe expression, but implementing it is proving to be troublesome due to circular dependency...

Type: enhancement
P1 high

Event-bound values are not entirely just Expression type, but List of statements (specifically ExpressionStatement). Adjust the ast to store these values instead of just "expression" type.

Type: enhancement
P1 high
S1 high

PR #345 in analyzer; once added remove the error from plugin to avoid redundant.