Max Kim

Results 14 comments of Max Kim

We'll add a fix for this shortly. We're still treating directive bindings input `[virtualScroll]` and `virtualScroll` as the same when they shouldn't be in the case where input and directive...

EDIT: Discussed with Mike - and I was confusing what was going on with the error flag. > Is there a way to improve the message. (instead of "is not...

> Perhaps it's just an issue because I had so many false hints and warnings in the past because of the early stage of the plugin. When I start trusting...

Hi @brianopp , sure - we can take a look at this scenario and provide some way to provide a meaningful message.

Making the LetBinding into a visitor? Or improving the visitor flow to work with the two newly added AST nodes?

Ah I see what you mean. I think it would be good to find a way to create a single visitor that generates an AST that fits our plugin needs....

We could possibly add the 1-off mispelled error detection and recovery into the angular_ast. It's already scanning for seemingly 'dangling close tags', we could add another layer of logic such...