mikedennis
mikedennis
getbalance should be there. Here is a test https://github.com/stratisproject/StratisBitcoinFullNode/blob/master/src/Stratis.Bitcoin.IntegrationTests/RPC/RPCTestsMutable.cs#L18-#L35 This RPC is in the wallet feature, is that included on the node?
Ditto for gettransaction It's also already in the wallet feature and requires a wallet.
I believe its safe and managed. Here's a good article I found on it https://msdn.microsoft.com/en-us/magazine/mt814808.aspx I think very useful tool for low level stuff and should make porting some C++...
As per #3356 getblockheader needs to be enhanced to be compatible with NBitcoin
> What's left to do on this? Are you able to help?
Very interesting - just to confirm the issues around ThreshholdConditionCache and WitnessCommitmentsRule are only appearing on RegTest but not on TestNet or MainNet?
Cursory investigation of logic looks same as core so not sure why behaviour is different. Equivalent Bitcoin Core sections: Network: (logic looks same to me) https://github.com/bitcoin/bitcoin/blob/5961b23898ee7c0af2626c46d5d70e80136578d3/src/chainparams.cpp#L288-L296 ThresholdConditionCache: (logic looks same...
Yes maybe that's it! @zeptin do you have an integration/unit test started we can use to verify this?
Good catch @dangershony . There also seems to be a discrepancy in bitcoin mainnet segwit settings as well. I will fix that as well. Bitcoin: https://github.com/bitcoin/bitcoin/blob/5961b23898ee7c0af2626c46d5d70e80136578d3/src/chainparams.cpp#L99-L102 Stratis Bitcoin: https://github.com/stratisproject/StratisBitcoinFullNode/blob/master/src/NBitcoin/Networks.cs#L68
@YakupIpek ok sounds good. I can look into that once we get some of these other build issues figured out.