Martijn Riemers comments

Results 9 comments of


                                            Martijn Riemers

Adds support for windows instances

Awesome work @crunchy234 ! Hope this gets merged, will be using your version in the mean time.

Adds support for windows instances

@crunchy234 You switched around the cases for Windows when `config.input.runnerHomeDir` is defined. See crunchy234/ec2-github-runner#1

Client side Request Logger doesn't log GET requests when logBody is set

I'm using the JdkHttpClient. This is happening because the body stream is not consumed in the `convertRequest` method. ```scala val publisher = FlowAdapters.toFlowPublisher( StreamUnicastPublisher(req.body.chunks.map(_.toByteBuffer)) ) if (req.isChunked) BodyPublishers.fromPublisher(publisher) else req.contentLength...

Sorted predicates

This what I could come-up with so far: ```scala final case class Sorted[D

Add the ability to specify an interface

Alright, what would be the best way to implement this in your opinion? Since the IPv4 and IPv6 addresses are gathered only once and reused for all records, I'm thinking...

Add Tests? And What to do for next time.

Go for it!

Fix for endpoint_params #202

Any update on when this will be merged?

MoneyContext should be abstract class

I'd like to second this. I want to write a `MoneyContext` that makes an external API call for the currency requested. Loading everything in advance eats away my maximum allowed...

MoneyContext should be abstract class

That wasn’t an issue for me personally because I only use this library for Ammonite. This does feel like a complicated issue that needs a lot of thought. If it...