ec2-github-runner icon indicating copy to clipboard operation
ec2-github-runner copied to clipboard

Adds support for windows instances

Open crunchy234 opened this issue 3 years ago • 8 comments

This change allows windows instances to be launched and used in the same way as Linux instances.

crunchy234 avatar May 13 '22 03:05 crunchy234

@machulav @crunchy234 I love this PR! While I can't speak to the goodness of the code, i really would love this functionality. I've really loved this Github action with my linux github runners, and I would love to use it with my Windows runners.

rsmall-apira avatar Jun 08 '22 15:06 rsmall-apira

Thanks @rsmall-apira.

We are already using it as part of our CI workflow, and it is working well so far. this is the marketplace link if you want to use it yourself.

crunchy234 avatar Jun 08 '22 19:06 crunchy234

Awesome work @crunchy234 ! Hope this gets merged, will be using your version in the mean time.

mhriemers avatar Jul 08 '22 13:07 mhriemers

@crunchy234 You switched around the cases for Windows when config.input.runnerHomeDir is defined. See crunchy234/ec2-github-runner#1

mhriemers avatar Jul 08 '22 14:07 mhriemers

@crunchy234 You switched around the cases for Windows when config.input.runnerHomeDir is defined. See crunchy234#1

@mhriemers Thank you very much for this fix! This has now been merged and released as windows-support-7

crunchy234 avatar Jul 10 '22 20:07 crunchy234

I think there are syntax errors where backticks were replaced by single quote, in linux user-data section, the vars substitution doesn't work so runner won't start. i'm trying the windows now, but it never connects, wonder why it might be.. the 30 seconds timeout seems short, is it all the time allowed for windows to get reachable, or it's just the interval it checks once in 30 seconds?

await waitUntilInstanceRunning({client, maxWaitTime: 30, minDelay: 3}, params);

Dmitry1987 avatar Jan 04 '24 19:01 Dmitry1987