Adds support for windows instances
This change allows windows instances to be launched and used in the same way as Linux instances.
@machulav @crunchy234 I love this PR! While I can't speak to the goodness of the code, i really would love this functionality. I've really loved this Github action with my linux github runners, and I would love to use it with my Windows runners.
Thanks @rsmall-apira.
We are already using it as part of our CI workflow, and it is working well so far. this is the marketplace link if you want to use it yourself.
Awesome work @crunchy234 ! Hope this gets merged, will be using your version in the mean time.
@crunchy234 You switched around the cases for Windows when config.input.runnerHomeDir is defined. See crunchy234/ec2-github-runner#1
@crunchy234 You switched around the cases for Windows when
config.input.runnerHomeDiris defined. See crunchy234#1
@mhriemers Thank you very much for this fix! This has now been merged and released as windows-support-7
I think there are syntax errors where backticks were replaced by single quote, in linux user-data section, the vars substitution doesn't work so runner won't start. i'm trying the windows now, but it never connects, wonder why it might be.. the 30 seconds timeout seems short, is it all the time allowed for windows to get reachable, or it's just the interval it checks once in 30 seconds?
await waitUntilInstanceRunning({client, maxWaitTime: 30, minDelay: 3}, params);