Faijul Amin
Faijul Amin
@ChiaHungDuan Thank you very much for the suggestions. We will submit a format PR soon.
@ChiaHungDuan @penpornk This PR is a formal PR. Please help reviewing this.
@ChiaHungDuan @joker-eph Thank you very much for reviewing this PR and the suggestions. I have addressed all. Please check it.
@ChiaHungDuan Thanks! again for the reviews. I have addressed those. Please check.
@rdzhabarov @ChiaHungDuan Any update on this PR?
@rdzhabarov Thanks! for the review. I have addressed the comments. Please check.
@rdzhabarov Thanks! for the review. I have addressed the comments. Please check.
@rdzhabarov I have addressed those. However, I am not sure how to run clang-tidy on tensorflow repository. Please check if it passes now.
@rdzhabarov Please let us know if the PR caused any more failures or not. Thanks!
> @mdfaijul these are the failures > > ``` > tensorflow/core/transforms/remapper/remapping_helper.h:26 ClangTidy: do not use unnamed namespaces in header files > tensorflow/core/transforms/remapper/remapping_helper.h:65 ClangTidy: unused function 'GetTfgOpName' > ``` > >...