Martin Velay

> You need to deassert `sha_en` after context switching https://github.com/ballifatih/opentitan/blob/mv_hmac_impl/sw/device/lib/crypto/drivers/hmac.c#L191, and `sha_en` must stay deasserted when you write context back so that it can flow to `prim_sha2.sv` Hi Ghada, Is...

Hi @andreaskurth, It is now ready to be merged according to me.

Closed as https://github.com/lowRISC/opentitan/pull/23942 has been merged

Thanks a lot Rupert for working on this. I wonder why it has never been raised before. Do you have any clue?

@rswarbrick, I have "cherry-picked" your modification on the master and your commit fixes the issue I raised. It works well for tests `ac_range_check_shadow_reg_errors` and `ac_range_check_shadow_reg_errors_with_csr_rw`. Command: `util/dvsim/dvsim.py hw/top_darjeeling/ip_autogen/ac_range_check/dv/ac_range_check_sim_cfg.hjson -i ac_range_check_shadow_reg_errors...

This PR can also be reviewed, it will require a rebase as the following PR is required to be merged first: - https://github.com/lowRISC/opentitan/pull/26859

Hi DV team (@rswarbrick, @hcallahan-lowrisc, @antmarzam, @KinzaQamar) Here is the PR I was talking about earlier today. I was expecting to have something in better to share by the end...

Status update: I have pushed all my changes. This PR is still not ready, the reset is not happening as it should yet. I need to pause this activity to...

Was this last push only a rebase or should I actually re-review it thoroughly?

Hi, I've used a similar format as Rupert [here](https://github.com/lowRISC/opentitan/pull/24434#issuecomment-2368101150) but I used a CLI tool from Andreas (thanks to both of you!). The following command is giving the results I...