opentitan icon indicating copy to clipboard operation
opentitan copied to clipboard
verified publisher icon lowRISC

[hmac/dv] Cleanups and coverage fixes/improvements

Open martin-velay opened this issue 1 year ago • 4 comments

  • fix and improve coverage model
  • fix couple of minor SCB issues
  • rename couple objects to be more relevant

martin-velay avatar Apr 30 '24 07:04 martin-velay

(I'm aware that this is currently a draft, just assigned Rupert and me for awareness and so we can get back to you quickly once the PR is ready for review.)

andreaskurth avatar Apr 30 '24 08:04 andreaskurth

This PR now contains commits that aren't related to HMAC. Please rebase on master and drop them.

andreaskurth avatar Apr 30 '24 15:04 andreaskurth

You probably have to rebase on master to include CI fixes that should get the failing CI checks to pass

andreaskurth avatar May 03 '24 18:05 andreaskurth

Hi @andreaskurth, It is now ready to be merged according to me.

martin-velay avatar May 08 '24 14:05 martin-velay

CI checks were failing. Although I don't think the failures are caused by this PR, it would still be better to have all checks pass before merging. I rebased on master to check if that resolves the CI problem.

Other than that, this LGTM

andreaskurth avatar May 09 '24 06:05 andreaskurth

As this PR only touches DV code, it cannot cause the observed CI check failures on FPGA. All other CI checks pass. Merging

andreaskurth avatar May 09 '24 09:05 andreaskurth