Margaree Peacocke
Margaree Peacocke
Some dialog tests were re-enabled in this PR https://github.com/BrightspaceUI/core/pull/1139
Remaining skipped tests (from this issue) are: - [ ] `dropdown-content`: `scroll-top-shadow` - [x] `dialog`: `scroll top shadow`
Will open a fresh PR for this.
I'll be opening a fresh PR for this.
will open a fresh PR
This PR has been added to the [Jira ticket](https://desire2learn.atlassian.net/browse/GAUD-5381) notes, so closing this until it gets worked on.
> ... I mean vdiff failed, but is it just me, or do the existing goldens just look broken? Agreed! It looks like it was me who did that and...
Closing as this is now fixed.
> This looks good to me. > > Is the intent to put this in for June or July release. Given branching tomorrow. Good question - I'll merge post-branching.
Closing in favour of https://github.com/BrightspaceUI/core/pull/5674 which is simpler.