core icon indicating copy to clipboard operation
core copied to clipboard

Table updates: table-col-sort-button: Accessibility improvements [GAUD-6125]

Open margaree opened this issue 1 year ago • 1 comments

Jira ticket

We want to add a title and aria-description to the button based on the state of the component. data-type attribute was added in order to use proper phrasing. If this seems like a good pattern, usages of d2l-table-col-sort-button will be updated to use data-type and in the meantime will fallback to the numbers phrasing (will check with Nicole as it's possible we'd want to just fallback to "Sorted").

margaree avatar May 02 '24 19:05 margaree

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-4651/

[!NOTE] The build needs to finish before your changes are deployed. Changes to the PR will automatically update the instance.

github-actions[bot] avatar May 02 '24 19:05 github-actions[bot]

will open a fresh PR

margaree avatar May 27 '24 18:05 margaree