Marcin Wachulski
Marcin Wachulski
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/a5445b0afb8b350417b6e6ab3160554967bc151f/contracts/token/ERC20/extensions/ERC20Votes.sol#L97 Could you improve wording of that function docs? It's unclear which checkpoint from the ordered list is returned. E.g.: ``` /** * @dev Lookup a value of the latest...
Currently we output in deployments.json `multisig: false` for non-multisig deployments. That adds unnecessary clutter. multisig: true should only be added for multisig related scenarios
When network is provided to mars in format `http...` then in deployments.json entries are saved under 'unknown' node. Allow for network naming overrides.
I want to store frequently used mars configuration in a file. Especially when there's a need for complex structure for some extension feature (e.g. multisig) ```json { "multisig": { "gnosis":...
There is implicit limitation that the multisig batch tx cannot exceed gas limit, otherwise it reverts. Improve the situation. Idea - try to simulate (dry-run) the batch tx execution and...
Currently some logs go into console directly and some through the logging utility (to console or file or both). Make it consistent (through a single logger that decides where to...
Currently `Options` takes every parameter used in Mars and there is no way to provide custom configuration (structure + provider). Allow for that in order to improve Mars extendibility (e.g....
Sometimes verification tests fail CI on some integration parts. Unit tests and CI runs should be infra agnostic/reliable. Fix this See: https://github.com/EthWorks/Mars/runs/4659517684?check_suite_focus=true Verification 579 | 1) does not throw if...
Currently some Mars use cases require ``` import { Address } from 'ethereum-mars/build/src/symbols' //... contract[Address].map(....) ``` to refer to contract's address before it's deployed and resolved (known) Either expose symbols...