maksimkim

Results 4 comments of maksimkim

@cuteant , the change breaks existing TlsHandler tests when checking EmbeddedChannel.Finish(): https://github.com/cuteant/SpanNetty/blob/9f31f09ca110c6a3994966f860ee54b6a1836d75/test/DotNetty.Handlers.Tests/TlsHandlerTest.cs#L126 It expects channel not to have any outgoing messages but the Finish() itself causes TlsHandler to write another...

@cuteant , also the regression is introduced in this PR: https://github.com/cuteant/SpanNetty/pull/65 Prior to that the promise for empty buffer write was completed in place without writing to channel: https://github.com/cuteant/SpanNetty/blob/34a24e358bf03178075cd90c7d7a319660232481/src/DotNetty.Handlers/Tls/TlsHandler.Writer.cs#L161 I...

Is this because of alpn on sslstream?

But isn't it available in netstandard2.1?