SpanNetty icon indicating copy to clipboard operation
SpanNetty copied to clipboard

Drop support for legacy target target framework

Open maksimkim opened this issue 4 years ago • 7 comments

Seems like explicit support for net451,net471,netcore2.1,netcore3.1 complicates dependency management. Does it make sense to completely drop support for net451 and support the rest through netstandard 2.0? So list of supported versions will reduce to netstanard2.0, netstandard2.1, net5.0.

maksimkim avatar Jul 19 '21 23:07 maksimkim

Windows desktop applications(winforms/wpf) isn't fully supported in .NET Core, starting with the .NET 5.0 release, it’s not a problem anymore. so there is really no need to keep support for .netfx 😃 'dotnetty-common/Handlers' module : still need to continue to support .net core 3.1

cuteant avatar Jul 20 '21 10:07 cuteant

Is this because of alpn on sslstream?

maksimkim avatar Jul 20 '21 15:07 maksimkim

Yeah

cuteant avatar Jul 20 '21 16:07 cuteant

But isn't it available in netstandard2.1?

maksimkim avatar Jul 20 '21 16:07 maksimkim

@maksimkim image I was wrong,:stuck_out_tongue: only 'dotnetty-common' module : still need to continue to support .net core 3.1

https://github.com/cuteant/SpanNetty/blob/main/src/DotNetty.Common/Internal/TextEncodings.Utf8.NetCore3.cs https://github.com/cuteant/SpanNetty/blob/main/src/DotNetty.Common/Internal/SpanHelpers.Byte.cs

cuteant avatar Jul 20 '21 17:07 cuteant

what I thought was to provide a unified impl(for encoding/span) that could be called by dotnetty.buffer in every targetframework...... so I copied some code from corefx

cuteant avatar Jul 20 '21 17:07 cuteant

and also , like this code: https://github.com/cuteant/SpanNetty/blob/46f4abe246a7e7f8faefa684f3411d4d8916c757/src/DotNetty.Buffers/PooledUnsafeDirectByteBuffer.cs#L113-L115 is able to execute in netcoreapp2.1 but not in .net standard 2.0

cuteant avatar Jul 20 '21 18:07 cuteant