Jakub Majocha

Attempt to identify tests that potentially trip #16712

1

So, NodeCode will pass or flow threadstatics through thread switches by means of `wrapThreadStaticInfo`. However, when we fall back to normal async, by e.g. `NodeCode.AwaitAsync` we're on our own. Let's...

Fix some possibly buggy usage of `UseDiagnosticsLogger`

2

## Description There was some odd behavior I noticed while trying to test AsyncLocal diagnostics state. `UseDiagnosticsLogger` creates a diagnostics scope and should restore previous logger on dispose. This should...

Simplify NodeCode `Using`

1

A draft just to try if it works.

Yet another NodeCode problem affecting AsyncMemoize

7

It looks like any call to `NodeCode.AwaitAsync` (there are many in Transparent Compiler) is at risk of getting wrong threadstatics? I've seen some randomness of that kind in #16701. Mostly...

AsyncLocal part 2 - replace all ThreadStatics and remove NodeCode and node CE

35

This supersedes or follows up on #16602 Introduction of Transparent Compiler revealed some instability w.r.t. `DiagnosticsThreadStatics`: https://github.com/dotnet/fsharp/pull/16576#issuecomment-1910321553 #16576 #16589 Turns out we used `[]` to keep a compilation-global `DiagnosticsLogger`, and...

Transparent Compiler: discrepancy between signatures and source files not reported in diagnostics

4

Basically, diagnostics for not implemented stuff in signatures (FS0193) don't show up. Not when you edit the implementation, and not in the background solution analysis. You need to build to...

AsyncMemoize: do not cancel and restart jobs that are being requested

10

This utilizes changes from #16533 The idea is to never cancel a job that is awaited by someone. Basically cancelling a `Get` does not cancel the cached computation if there...

`else if` handling misplaces directive located between the keywords

2

Issue created from [fantomas-online](https://fsprojects.github.io/fantomas-tools/#/fantomas/main?data=N4KABGBEDGD2AmBTSAuKBLAZmALgJwFdFcALRAOzAAYAdPG8xAGwGdE6GBiLMAMQHl%2BHShDA9MAQ1bEcZSgEZhosMzbDOFeFiXLRAJmGQANOChscOdOQDmLVGADapiKF1QAJDgCeAB2RpIKxxjZ1FIdwA3KSJ7JzcIKhN4qABJciRyHABldAAvZCT4gBZQiABdUIBfQpdSj28-e0DMkLdwqKYYtDj4%2BRrdSABZCQAPABkrRDGKa1lW3r0qOorlatDXAc9ffyhNfkwJxizvJgK69uidnrc9fuVIAFF0-cOz5MgmTEhlqv6N%2B62jQCACNYLAmPMAR0uo46hAAMx3MJpNh4HC8KxSAByiAA7kxJpDdPgiD9Vn9zoCdpBQeCiRALp0rnCwEUkQysj4JNBEAAhRCYWB4RAABQkeAkAFtEDhEHh6aISYgyaI1sp-mEqU1aRCkYyYdddABWdlQTncvkCoVTWC4uXQCRsNIRWAOyywcgKiBKlUQNWiDUMrUgsG6ynQ5nJABspsg5p5-MFwoAqj4-HgHU7yC63egPV6wJJpL6wP7am1g1AdQr9ZH4gB2WPxy1JxAAYSYjpYbY9LBJ0BwQoLRbYJbLYED9W22tDNcil1iLIAHE2uQmrcLBohJcC5cOpKO3CtVRSKw1qdW9fOmYvkgBOVcWxPWntMfOmkfKo%2B-daU88zukrwjW9ekSFk4zXRAAEFMFlPAe0lSUJALH1v3JX8z2nENAPDBduhZeQ%2BnA5tn2FLJt3QOA309D8Dy-XRjz9U9Nn-bCwwrYD8OSeRbmIyCYLg8jJUo8F3xZVCGJ-dU-ywqtZyAvDYW4xE%2BItKC8FgAh0gAEWYdBhLglDCHo5RGNLZiAVYjAWgUm8uN6NlwOGEYUkwAAVOQshIIUcAAdXQeA5lNJY0JPDCWNk5pglsg0CJNJzRlcjyKAeaQvJ8-zApIAsoxCyT0OkzCgWs6LcLspTehjBKXPITB0BGfh0wkQc8AeEYfGFFgWDzGjlzy0ypIDGTiqiudOIqtx5EbaqACVEDgPB4EyoKWSKfrRDM8dJ3CKzRpiutJpXWb5qFeAsQIHc5X2FJZUlOxTXkMcLM1XbJQIJhLAJRheCFJCLDlNzp32kDJofcC5oW%2BBBnez7Jh%2BvA-sM2NoBIcVuTggB9XEArmJ7wssyKgjGxTDWURZY2c9SJS8fg8AmPtluy00l3W8pBvLCKRqJ4H7JuIj3kpvBqdp%2BmcHOy68Gu277oIvHCs56k3o%2B9AvsQeHEYBoGyti5I9F494qYkGm6fQPtoeV1X1eapHwJRtGBzlLGceyuWhqK6lue1g7dD0FSBdGAA1S5eSsLQbEZgsWddjmCa5myvZBn3HP9kZeC0gcepD9IrGsCPTTW6OJ2Gj3444kmWT0eKU%2B02AcAAcRlNqOsQLqerzvrC%2B2ysaXkhPeZ9qr3hxfFJn5HA7QoQG-F0uryHQd1yCg9ItwlmXkgkgaCrdhWAPYzZxtJ-RpoNglrHINPyAzj0cjP5qCGFNzYDSDIcGanr92LUKmPxl7IsvPuJo%2ByOifOC5A34RBtDYFeu48AzysPPHqa94ifk7sXXexNyqHwgHoMGAsYboFeGMKUwJ4ASA7LAbqNhh6qw-oefKYV5axwvL3MumCWTwjAu8Jucp9IUFfkwAA0ogRAPhn58LSLyCUl8mYshQV-cyP8gy7X-qwnW8R4T83iJAXknZyAAGtXgsHUppdIOI%2ByIChvg1WTdOrdV7EZUk8itpoLYhgtRbh4T6y0bycUpFEDaVNtAPA%2BlMSyngMmOeHpdLQE7BKBetCTIbXZkXd2TQlaw0YJI7keiZTHC8KcNx3tlDwj9lo82GS%2BQSmgDk7IJw3haKCVKPw8BvhOOekowmpd97l2SPCZOWihEiOcuLGB%2BwdESH0YYgsj02mKKnCNFR3S2G9Krlo44wSByDAQPUtwcj6F%2BlMGUQogQWC8G6vYFBlQgA) #### Code ```fsharp if true then 0 else #if FOO if false then 1 else #endif 2 ``` #### Result ```fsharp if true then 0 else...

Use Visual Studio Community Toolkit to access common services, fixes #44

2

I did some experiments to resolve #44 and thought I might as well make a PR out of it. This adds [Visual Studio Community Toolkit](https://learn.microsoft.com/en-us/visualstudio/extensibility/vsix/visual-studio-community-toolkit?view=vs-2022) as dependency. See also: [https://www.vsixcookbook.com/](https://www.vsixcookbook.com)...

Extension does not load when a folder is opened in VS instead of a solution

1

I have a folder with .fsx scripts. When I open it in Visual Studio 2022, formatting doesn't work, because the package is not loaded. It waits indefinitely for `FantomasVsPackage.Instance` here:...