fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

Attempt to identify tests that potentially trip #16712

Open majocha opened this issue 1 year ago • 1 comments

So, NodeCode will pass or flow threadstatics through thread switches by means of wrapThreadStaticInfo.

However, when we fall back to normal async, by e.g. NodeCode.AwaitAsync we're on our own. Let's say there's an await that causes thread switch. Any global DiagnosticsLogger access after that will potentially target the wrong logger. This may be completely benign, or may cause some problems in other threads, see #16712.

This adds some instrumentation to look for such events in the CI. If this works correctly, every failed test here is potentially problematic.

majocha avatar Feb 21 '24 09:02 majocha

:heavy_exclamation_mark: Release notes required

@majocha,

[!CAUTION] No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md No release notes found or release notes format is not correct

github-actions[bot] avatar Feb 21 '24 09:02 github-actions[bot]