Michael Gibney

This all looks great to me. I wasn't intending to press on #35, and I'm fine with it being closed; I was just thinking out loud about some of its...

Had to change `@engine_args` to `@engine_params` in lines 80-81, to match the declared attr_writer on line 51, but with that small change, this works great! Example code as it worked...

I'm inclined to leave this as-is for now (with the recent minor addition of the `merge.renameLimit` increase, which I think is probably mostly cosmetic wrt suppressing a warning that I...

fwiw, I think the gradle precommit is failing on a nocommit comment marking a question about why TOLEADER distrib commit errors aren't propagated back to the client ... not really...

Cleaned this up quite a bit. The essence of what's happening here is pretty straightforward: 1. ValueSources need to supply their own SortField, but in Solr they need to supply...

LGTM. I was looking at SOLR-16046 as well and opened #842, which I think should complement this PR nicely. One thing I found myself wondering, wrt the `killer` thread as...

From @dsmiley's [comment on PR 815](https://github.com/apache/solr/pull/815#issuecomment-1106880696): >I suspect the searcher and/or request being open after the core close will keep the core increment one higher and thus not actually closed...

Pending feedback/objections, I plan to merge this in the coming week.

On a naive/toy example (1,000,000 docs, terms facet on unique `id` field -- so, field cardinality of 1,000,000), core in tmpfs, comparing `q=*:*&rows=0&json.facet={blah:{type:terms,field:id,sort:"index desc"}}` against the same with `index asc`,...

Thanks @risdenk! Both the "SolrZooKeeper" and the always-synchronous close() are codependent, iiuc. My hesitance to go full "blocking close()" across the board comes down to the fact that introducing a...