Mabel Zhang

Results 52 comments of Mabel Zhang

Beautiful! We can possibly mock up some corals for underwater with that, I imagine. Could you suggest to the artist to do a generator for schools of fish or jellyfish?...

@AndrejOrsula Friendly ping! The code looks good, just need some more explanation in the tutorial so that readers have more context about what the code is doing, and the Ignition...

Thank you for iterating! This is awesome! I'll read through the updated tutorial soon. > COLLADA exporter works terribly on certain models for some reason (material issues Yes! I've seen...

DCO is failing. It'll have to pass before we can merge.

Ah the web UI button for directly committing suggestions is tricky to use when there's DCO. For future reference, when you want to use that button again, you can manually...

Bionic CI is failing on some style items ``` /github/workspace/src/systems/triggered_publisher/TriggeredPublisher.cc:747: Lines should be

Looks like just style errors before we get to the actual tests

Good find! Thanks for troubleshooting the flaky test! It seems reasonable what you did. It was hard to reproduce for me even the first time, so I can't really test...

ABI checker is failing in the checks below https://build.osrfoundation.org/job/ignition_gazebo-abichecker-any_to_any-ubuntu_auto-amd64/5635/API_5fABI_20report/ Removed Symbols 7 ``` EntityComponentManager.hh, libignition-gazebo6.so.6.12.0 namespace ignition::gazebo::v6 EntityComponentManager::HasPeriodicComponentChanges ( ) const _ZNK8ignition6gazebo2v622EntityComponentManager27HasPeriodicComponentChangesEv Gui.hh, libignition-gazebo6-gui.so.6.12.0 namespace ignition::gazebo::v6::gui createGui ( int& _argc,...

ABI check is the last thing before approval and merge. The other test failures look irrelevant since this PR only touches triggered publisher.