m.

Investigate and clarify better /Z7 necessity for MSVC 2010 and higher when using PCH

8

I think the new note on the /Z7 flag gives the impression that this is solution aimed at supporting 2010 (at the expense of newer editions) whereas it's really a...

README should warn ESP.qcow2 is volatile (modifiable by the booter, etc.) and so it should be backed-up in case it ends up in an unbootable state

1

My ESP.qcow2 was modified so it no longer booted and stopped at the Shell> prompt. I wasted some time retracing my steps before trying to redownload it to start over....

Can the CMake build instructions on OpenXR-SDK mention these missing externals?

1

``` -- Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE) (Required is at least version "3") -- Enabling OpenGL support -- Could NOT find Vulkan (missing: Vulkan_LIBRARY Vulkan_INCLUDE_DIR) -- Could NOT find...

https://github.com/zturtleman/mm3d/blob/master/src/libmm3d/glmath.h

https://github.com/zturtleman/mm3d/blob/53b0d1b33412bddacd65559f41d5511b9050a27a/src/commands/edgedivcmd.cc#L109-L112 Unrelated: Below is some code for adding texture coordinates to this command.. ``` float st[2][3],dst[2][3]; model->getTextureCoords(tri,st); //2022 for(int i=2;i-->0;) { dst[i][a] = (st[i][a]+st[i][b])*0.5f; dst[i][b] = st[i][b]; dst[i][c] = st[i][c];...

Zero divide is missing from normalize/normalize3 (glmath.h/glmath.cc) functions

2

https://github.com/zturtleman/mm3d/blob/master/src/libmm3d/glmath.cc#L875-L892 (Also found inline in the header and a Quaternion method.) FWIW I was just testing the "Boolean" (model_bool.cc) code (adding texture coordinates to it) and it produces 0 length...

https://github.com/zturtleman/mm3d/blob/53b0d1b33412bddacd65559f41d5511b9050a27a/src/implui/groupclean.cc#L73-L88 The basic problem is the materials need to be removed last since they depend on groups owning them. But it seems like the removal functions both need to run...

[ double dmax[4] = { DBL_MIN, DBL_MIN, DBL_MIN, 1 };](https://github.com/zturtleman/mm3d/blob/53b0d1b33412bddacd65559f41d5511b9050a27a/src/libmm3d/md3filter.cc#L2085) I was just checking for this common mistake (owing to C stupidity in defining INT_MIN and FLT_MIN/DBL_MIN.)

Material/light parameters are backward, should be swapped

2

MM3D has a lighting set up that makes no sense, it's especially bad in the texture view where lighting pretty much washes out completely so it's as if there's none....

Did you have an interest in OpenGL ES at one point? (Still invested?)

2

I'm not suggesting changing any existing OpenGL code, but do you have any input on what if there were either a capture system or alternative OpenGL ES path? By capture...