Lyza Gardner comments

Results 48 comments of


                                            Lyza Gardner

DHT11 (via i2C nano backpack)

Hi, @lezabour ! Could you tell me more about your setup? What kind of board is the Nano (backpack) currently connected to physically? Is it connected to an Arduino Uno?...

UI inconsistency in Group menu sub-items

I'd like to have `cursor:pointer` on the actions if nothing else.

Text inside SVGs disappears when highlighted by Hypothesis

I've reproduced. This is interesting, however: the text in question is within an SVG...

Re-render Adder when `annotationsForSelection` property changes

@robertknight Pretty sure you meant to assign me as a reviewer, not to the PR itself, so have updated assignments accordingly :)

Unusable instructions shown on empty Page Notes tab when using “clean” theme

@robertknight It seems, logically, that the clean theme has a dependency on the `experimentalNewNoteButton` — that is, is there any way to solve this issue without rendering that button? Put...

ValueError: :userid isn't a valid userid

I believe this is a fix for this: https://github.com/hypothesis/h/pull/5760 — just need time to get back to finishing up that PR. Anyone else is welcome to take this.

ValueError: :userid isn't a valid userid

@jon-betts I've no attachment whatsoever to my (inelegant) fix. Please feel free to close mine and use yours.

Too-large URI gives error: "Saving annotation failed 500"

I'd like to propose a third "possible solution": change the way we're indexing this uniqueness constraint. Instead of enforcing unique on (`claimant_normalized`, `type`) as we do at present (https://github.com/hypothesis/h/blob/f41b7bfb7153006fd094bb0be4bdd2e6d5b28f95/h/models/document.py#L148), we...

Notebook close button positioning, styling need tuning

The close button has been updated since this issue was filed.

SPIKE: Browser focus doesn't shift to annotation when using VoiceOver + Safari for Mac on first annotation

@LMS007 I don't believe that's a public link.