Results 11 comments of luke

Thank you @LalitNarayanYadav! I have tagged you on the sub issue #7875 as this issue has a bit more still open. Could you leave a comment there when you're ready,...

Firstly, this is actually a bug coming from here: [FunctionCallNode](https://github.com/processing/p5.js/blob/2606c21ef4924bd995053193c1c8b66f3e014d25/src/webgl/ShaderGenerator.js#L523-L543) This is the error ``` Expected argument types: (genType, genType) Provided argument types: (int, float) ``` It infers `genType` to...

That would also fix it, but `genType` should also never be an `int`, and the actual error comes from calls to `pow` and `floor` receiving (and accepting) an `IntNode` as...

Looks good @perminder-17 ! I agree with @Garima3110, I don't think `shader()` should be changed to `fillShader()`. It's breaking, but I also think it's better to leave the name general...

> > `defaultStrokeShader` > > How about `lineShader()` @davepagurek ? I don't think I mind it, but it could be confusing to have two terms for stroke. I noticed that...

That’s what I was imagining, but then again its also not ideal as it doesn’t align well with the other shader hook functions `materialShader()`, normal etc which can’t be set...

Thank you, almost there! Could you also remove the unused variable `fn` on line 11?

Thank you for working on this! It looks good to me. @davepagurek could you review too?

Hey @LalitNarayanYadav, I'm redirecting you to this sub issue of #7849 so you can implement this! Thank you for taking this on, and please @ me for any questions. Make...

Hi @pratham-radadiya, thank you for your interest. I am currently trying to smooth this out a bit to make it easier to work on with a refactor. It should be...