Luke Holder

icon indicating a website link http://lukeholder.com icon indicating an email [email protected]

icon company @craftcms icon location Perth, Western Australia icon location I’m an Australian born web developer who likes to build useful things. I am currently working on Craft Commerce, a powerful way to sell things on Craft CMS.

Results 278 comments of Luke Holder

Consider trademarking zig and the zig logo

Was the change in 608770bf7303613c18a8c3faf284516fa31072f0 an attempt to solve this ticket?

Added currency as an additional field based on the location, and cache results in the storage folder.

Wow, I don't know how I didn't see this pull request... I cant pull it easily now as I have started to abstract geoip gateways in 1.2, but i will...

Deprecation error for Craft CMS fields with handle `order`

@brandonkelly do you mean the `order` being added to the `extraFields`?: https://github.com/craftcms/commerce/commit/a880bea6cc13b690507a8237891d17cb03b83236#diff-95df435f4aafb29ba3c6f6677aa982deR228

Deprecation error for Craft CMS fields with handle `order`

@Anubarak Just to confirm, where did you add the `order` field? to the Product or the Variant?

Don't send Discount Name to gateways

https://linear.app/craftcms/issue/COM-35/fix-field-descriptions-on-all-namedescription-fields-for-discounts

[3.x]: Cart emptied after x minutes despite session or activeCart duration

This will likely be due to the PHP session time. We moved to a cart cookie in Commerce 4 to get around this PHP session limit.

[4.x]: Can't set default order status

@Sam-Black-0013 Confirm this is broken and will look into a fix.

Negative VAT when using coupon larger then order price

Please post all your tax rate rules (screenshot of the tax rate from the CP?), and well as the discount so we can try and reproduce.

Available shipping methods are recalculated every time the order is retrieved

Could you cache the API request using a hash of the information used to make the api request? This is what we do for the taxjar plugin: https://github.com/craftcms/commerce-taxjar/blob/master/src/adjusters/TaxJar.php#L119-L141 That way...

Available shipping methods are recalculated every time the order is retrieved

This is only a performance issue because you are using a live rates API for the shipping method price, that's the expensive part. Asking for the available shipping methods for...