commerce icon indicating copy to clipboard operation
commerce copied to clipboard

Don't send Discount Name to gateways

Open engram-design opened this issue 6 years ago • 2 comments

At the moment, when sending orders (with PayPal, but probably others - anything using https://github.com/craftcms/commerce-omnipay), if the order includes a discount, it uses both the name and description in the order details.

This is fine, but the field instructions in the CP clearly state that the name is what its referred to the CP, which is kind of inferring that its not shown to customers. As such, our clients are using this to store non-customer facing info, but its being shown regardless.

See https://d.pr/free/i/kaA1XE

Note I've tweaked the instruction text on the second field for clarity for this client.

Unsure if it a change in https://github.com/craftcms/commerce-omnipay/blob/master/src/base/Gateway.php#L704-L705 or clarifying the field instructions?

engram-design avatar Nov 11 '19 01:11 engram-design

@lukeholder Any update on this?

gojira32 avatar Dec 06 '19 00:12 gojira32

https://linear.app/craftcms/issue/COM-35/fix-field-descriptions-on-all-namedescription-fields-for-discounts

lukeholder avatar Jul 02 '21 13:07 lukeholder