Vincent Lostanlen comments

Results 194 comments of


                                            Vincent Lostanlen

Add support for filenames beginning with a dash

@rabitt what are your thoughts?

Tagged releases are out of sync with PyPi

Hello, what should we do exactly?

Tagged releases are out of sync with PyPi

1. it's not obvious that we should do this. PyPI releases are application-oriented and typically do not include unit tests at all. If you need to run your own unit...

Tagged releases are out of sync with PyPi

Agreed with 1. We need green light from @rabitt for 2.

Fix bitrate parsing for cross-platform environment

Sounds good, many thanks. I don't understand the logic of `elif greek_index`, could you please explain?

splitting a file with silence

Yes. See: https://github.com/rabitt/pysox/blob/master/sox/transform.py#L2769

splitting a file with silence

i'm not sure if this is featured in pysox. it might be good to bring this up to @rabitt

Make build_array function consider requested output file_type

Thanks. Could you write a unit test for this? How does this affect the behavior of pysox? Is it backwards compatible?

Make build_array function consider requested output file_type

Thanks @dmitriilazukov. LGTM

Make build_array function consider requested output file_type

@rabitt this is ready for merging IMO