marl
Fix bitrate parsing for cross-platform environment
Previous version of parsing was unable to get valid content
eg. when output ends with '\r' character what is possible
in cross platform environment. New parser version is resistant
for any line ending.
Moreover parser is insensistive for prefix letter size, see bug:
https://github.com/rabitt/pysox/issues/119#issuecomment-732651583
Signed-off-by: Karol Trzcinski [email protected]
Sounds good, many thanks.
I don't understand the logic of elif greek_index, could you please explain?
I don't understand the logic of elif greek_index, could you please explain?
greek_index it's array of found greek letter indexes in output.upper(), so when any letters has been found then if greek_index will be True, otherwise False (for empty array).
( ... a few moment later ...) Hello again @ktrzcinx. With permission from @rabitt I am taking over the maintenance of pysox and prepare a new release (v1.5) on PyPI. I have push access on this repository.
I am keen to merge you PR. Other people have reported a \r bug on Windows: #159
Can you please write a test which triggers this bug on Windows and show that your PR solves it?
( ... a few moment later ...) Hello again @ktrzcinx. With permission from @rabitt I am taking over the maintenance of pysox and prepare a new release (v1.5) on PyPI. I have push access on this repository.
I am keen to merge you PR. Other people have reported a
\rbug on Windows: #159Can you please write a test which triggers this bug on Windows and show that your PR solves it?
test is in #163
