Laura Jarin-Lipschitz

Results 11 comments of Laura Jarin-Lipschitz

@versatran01 https://github.com/KumarRobotics/kr_planning_msgs

OK, @XuRobotics and @versatran01 , sorry leaving this open for so long, but I think it is ready for a test. The only thing remaining that I did not do...

Also I assume the docker build github action should be run? I'm not sure how to trigger that?

I think you mean https://github.com/KumarRobotics/kr_autonomous_flight/blob/master/autonomy_core/map_plan/mpl/include/mpl_basis/data_type.h as the 3rd one

Yes, I agree...On the other hand there's only little name alias statements in that file. The easiest solution would be one copy in kr_planning_msgs, which doesn't make too much sense....

I will add a namespace for data_ros_utils

Sure, I don't feel strongly In the meanwhile I have discovered a small rviz bug that I will resolve before we merge

I found a bug in the rviz plug-in right before I left. Will address this weekend, sorry 😔

This is way later - but I believe you also need --no-deps for this to work as you intended, otherwise it builds all of the unbuilt packages' dependencies.

Under the principle of better late than never... I think this is now working. The changes needed were in https://github.com/KumarRobotics/kr_planning_msgs so the only change to this PR was rebasing to...