liyafan82

Results 9 comments of liyafan82

> I noticed that in the JIRA Julian mentioned he is working on https://github.com/julianhyde/calcite/tree/4159-simplify which might solve this case. It might be still good to postpone this PR a bit...

> > This forces the client to register all rel node types before calling the metadata service > > How ? If the client fails to register all node types...

> > > > This forces the client to register all rel node types before calling the metadata service > > > > > > > > > How ?...

> AFAIK, the custom node types for down-stream projects should usually be few, so how much performance could we gain to encourage an eagerly initialization for all nodes ? >...

@julianhyde I have updated the PR according to your suggestions in the ML. Could you please take a look?

> Could we expand the revise call to take a RelMetadataProvider as an argument. Then create a static variable using an interface with the revise call in RelMetadataQueryBase. This would...

We also simplify the DefaultDirectedGraphBenchmark benchmark in this PR.

@vlsi @xndai dear reviewers, do you have any more comments for this PR?