calcite icon indicating copy to clipboard operation
calcite copied to clipboard
verified publisher icon apache

[CALCITE-4155] Simplify IN expression of discrete values

Open liyafan82 opened this issue 5 years ago • 4 comments

See https://issues.apache.org/jira/browse/CALCITE-4155 After introducing the Sarg framework, we need to support it based on that.

liyafan82 avatar Sep 16 '20 02:09 liyafan82

@liyafan82 I will try to give a code review soon.

amaliujia avatar Sep 16 '20 06:09 amaliujia

@amaliujia Thank you in advance!

liyafan82 avatar Sep 16 '20 08:09 liyafan82

I noticed that in the JIRA Julian mentioned he is working on https://github.com/julianhyde/calcite/tree/4159-simplify which might solve this case. It might be still good to postpone this PR a bit to what is the outcome from 4159-simplify.

amaliujia avatar Sep 19 '20 04:09 amaliujia

I noticed that in the JIRA Julian mentioned he is working on https://github.com/julianhyde/calcite/tree/4159-simplify which might solve this case. It might be still good to postpone this PR a bit to what is the outcome from 4159-simplify.

@amaliujia Thanks for your investigation.

IMO, some of the ideas in https://github.com/julianhyde/calcite/tree/4159-simplify has already been implemented in https://github.com/apache/calcite/pull/2105, and merged into our code base. I am not sure if Julian is still working on it, so I opened this one.

Anyway, it sounds reasonable to postpone this and wait for some outcome from that PR.

liyafan82 avatar Sep 21 '20 12:09 liyafan82