Ilya Lipnitskiy

Results 9 comments of Ilya Lipnitskiy

Hi @talisein, I would like to merge this into [libcue](https://github.com/lipnitsk/libcue) if you could create a simple test case and submit a PR against libcue. If not then I may add...

It looks like the only exported symbol in libcue 2.0.1 that conflicts with libcdio is `cdtext_get`. That seems to be a problem. I suppose the conflict could be resolved with...

I'm not sure whether to call it a bug, but it has definitely caused missed test failures in my experience. At the very least, the current behavior is counterintuitive and...

You are right, it is documented, yet still error-prone. Any tips on how to enforce assertions on non-top-level conditions in a large test codebase? Is this completely out of scope...

I think protoc should allow for defining options at all levels in separate files, not just the file-level options. See https://jpa.kapsi.fi/nanopb/docs/reference.html#defining-the-options-in-a-.options-file for a variety of ways it can be done...

@macdja38 seems to have push access (see #235). Any comments?

Sure - feel free to submit a PR

Can you please add unit tests for these changes, just in case a later change breaks this behavior.

I added your commit to #85 and made you collaborator - feel free to close this if you wish.