Hao Liu
Hao Liu
hi @vkononov, thanks for coming up with a gem to make filling up PDF easier. However, I could confirm this is still an issue for Ruby 2.6.3, Rails 6.0.2.1, I...
however, it works perfectly under bare irb instead of rails console
I am wondering if you could do the following to set the MIN and MAX value ``` RankedModel::MIN_RANK_VALUE = 0 RankedModel::MAX_RANK_VALUE = RankedModel::MAX_RANK_VALUE*2 ```
> Thanks; is this ready for review? @leomayleomay > > Team - can we approve CI for this PR? yes, this is ready for review, if the team could approve...
@Datron it's my pleasure :) @srid will this check apply to .sql only or all the files?
> @leomayleomay we follow [conventional commit guidelines](https://www.conventionalcommits.org/en/v1.0.0/) for our commits, can you add that? I think chore or fix is appropriate here. @Datron thank you for letting me know :)
@srid @Datron I've made changes to switch to [eclint](https://pkg.go.dev/gitlab.com/greut/eclint) and lint .sql files only, please let me know if there are other types of files to lint, cheers
@srid the CI [failure](https://github.com/juspay/superposition/actions/runs/9223258312/job/25377253227#step:5:4208) seems to relate to devour-flake, please help out, I am running out of idea why it doesn't work for macos
> The pre-commit hook should be added to devShell shellHook too? Just like in `nammayatri`. indeed, I thought this PR was all about CI, now added to devShell
the pre-commit now works in devShell 