juspay
chore: Add a new check ensure .editorconfig rules are honored
Problem
This is to add a new pre-commit-hook check to ensure rules in .editorconfig will be honored, otherwise CI will fail
Solution
Introduce a new git-hooks.nix as part of flake modules, it will host the checks which will run a pre-commit-hook to ensure rules in .editorconfig will be honored, otherwise CI will fail
Thanks; is this ready for review? @leomayleomay
Team - can we approve CI for this PR?
Thanks; is this ready for review? @leomayleomay
Team - can we approve CI for this PR?
yes, this is ready for review, if the team could approve CI, I will see a CI failure due mal-formatted code
@leomayleomay Thanks for the contribution! @srid can you approve too? I can merge after that.
@Datron it's my pleasure :)
@srid will this check apply to .sql only or all the files?
@leomayleomay we follow conventional commit guidelines for our commits, can you add that? I think chore or fix is appropriate here.
@leomayleomay we follow conventional commit guidelines for our commits, can you add that? I think chore or fix is appropriate here.
@Datron thank you for letting me know :)
@srid @Datron I've made changes to switch to eclint and lint .sql files only, please let me know if there are other types of files to lint, cheers
@srid the CI failure seems to relate to devour-flake, please help out, I am running out of idea why it doesn't work for macos
@srid the CI failure seems to relate to devour-flake, please help out, I am running out of idea why it doesn't work for macos
The issue is not with devour-flake but with the pre-commit-run run derivation which is failing to build. You can use nix --accept-flake-config run github:srid/nixci build in order to run CI locally.
The pre-commit hook should be added to devShell shellHook too? Just like in nammayatri.
The pre-commit hook should be added to devShell shellHook too? Just like in
nammayatri.
indeed, I thought this PR was all about CI, now added to devShell