Leidong Wang comments

Results 79 comments of


                                            Leidong Wang

serial/windows_support.py: Fix data type conversion issue

Hi @nanliu-r Would you please help review this patch? I guess you will use this script too,thanks.

virtio_win_installer: add pretest for installer

Will discuss this patch this week.Thanks!

virtio_fs: use dd cmd to create file

Could you add the test results here, thanks! Btw, if it is a workaround, maybe we can add an annotation here.

virtio_fs: use dd cmd to create file

Hi @xiagao Any update about this PR?Thanks.

virtio_fs: delete usergroup before add a user

Hi @hellohellenmao Would you please help review this PR when you are free?Thanks.

virtio_win_installer: update installer repair function

Hi @xiagao Is this patch ready for review now?Thanks.

virtio_win_installer: update installer repair function

Hi @xiagao Would you please resolve the conflict and provide test results for this PR?Thanks.

Pvpanic: Memory Leak check

> Adding memory leak checking BZ 2149195 > > Signed-off-by: Ke MA [[email protected]](mailto:[email protected]) bz:2149195

Pvpanic: Memory Leak check

Pvpanic only need to modify `virtio_driver_sign_check`?Seems you also add a step to enable driver verifier to this case,but it is not our expected test scenario.We can discuss it privately.

Pvpanic: Memory Leak check

> Adding memory leak checking BZ 2149195 > > Signed-off-by: Ke MA [[email protected]](mailto:[email protected]) BZ:2149195