avocado-vt icon indicating copy to clipboard operation
avocado-vt copied to clipboard
verified publisher icon avocado-framework

serial/windows_support.py: Fix data type conversion issue

Open 6-dehan opened this issue 2 years ago • 2 comments

In Python 3, there is a clear distinction between string and bytes objects, so we need to convert the memoryview object to a bytes object. To fix this problem, we need to change the type of whole from a string to a bytes object.

ID: 2227 Signed-off-by: Dehan Meng [email protected]

6-dehan avatar Apr 16 '24 06:04 6-dehan

@leidwang ， could you please help to review it? (1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.vioser_in_use.with_reboot.guest_to_host.q35: PASS (385.52 s)

6-dehan avatar Apr 16 '24 06:04 6-dehan

Hi @nanliu-r

Would you please help review this patch? I guess you will use this script too,thanks.

leidwang avatar Apr 17 '24 07:04 leidwang

Hi @6-dehan

I think we can move this PR to ready status, and re-start/continue the review progress.Thanks!

leidwang avatar May 16 '24 02:05 leidwang

It's able to fix the issue, so please help to approve it and merge it @leidwang and @vivianQizhu

6-dehan avatar May 24 '24 04:05 6-dehan

@leidwang Any other comments?

vivianQizhu avatar May 28 '24 01:05 vivianQizhu

@leidwang Any other comments?

No more comments for me.Thanks!

leidwang avatar May 28 '24 01:05 leidwang