Siang-Yun (Sonia) Lee
Siang-Yun (Sonia) Lee
Are the results wrong, or just non-deterministic? In my opinion, producing non-deterministic but correct results is not counted as a "bug", although it is not preferred in an experiment setting....
Good to catch. Interestingly, there are like at least three different implementations of counting MFFCs in mockturtle, by different people 😅
Thank you for the contribution. A few things: - Updates to `lorina` should be made in the source repository first. It would also be great to provide a test case...
Thanks!
#567 will fix the issue with the second solution above. However, I will keep this issue open as the other possibilities (especially the last one) could still be discussed.
#586 fixes this issue better with `revive_node` (last option above). Changes related to `cut_rewriting_with_compatibility_graph` (including quality test) in #567 has been reverted.
Thanks for reporting. This part of the code is not well tested but is not planned to be worked on either in the near future. I would suggest to either...
So I just discussed with Heinz about this. As I guessed, it was not a conscious decision, but has simply evolved with needs. I think (though I haven't tried) calling...
Indeed, the overhead should not be too big, so I'm not totally against it. However, small overheads accumulate. The balance between pros and cons is not so clear to me...
I will leave it open in case there will be more discussions from other cases/applications in the future, as I see this as an unsettled decision.