mockturtle icon indicating copy to clipboard operation
mockturtle copied to clipboard

Hywang/fix sequential

Open Nozidoali opened this issue 3 years ago • 3 comments

  • fix BLIF reader/write BLIF for sequential circuits
  • consider sequential logic during cut enumeration and when collapsing mapped network
  • close #572

Nozidoali avatar Nov 09 '22 00:11 Nozidoali

Ready to merge if all tasks below are checked :))

  • [x] fix write_blif
  • [x] add test cases for write_blif that the previous implementation would fail.
  • [x] add test cases for name_viewed BLIF read/write

Nozidoali avatar Nov 09 '22 10:11 Nozidoali

Codecov Report

Merging #573 (6345890) into master (7a0f512) will increase coverage by 0.07%. The diff coverage is 97.36%.

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   83.05%   83.12%   +0.07%     
==========================================
  Files         164      164              
  Lines       21178    21244      +66     
==========================================
+ Hits        17589    17659      +70     
+ Misses       3589     3585       -4     
Impacted Files Coverage Δ
include/mockturtle/networks/klut.hpp 95.39% <ø> (ø)
include/mockturtle/io/write_blif.hpp 91.26% <94.73%> (+3.54%) :arrow_up:
include/mockturtle/algorithms/collapse_mapped.hpp 92.79% <100.00%> (+1.61%) :arrow_up:
include/mockturtle/algorithms/lut_mapping.hpp 94.33% <100.00%> (+1.25%) :arrow_up:
include/mockturtle/networks/sequential.hpp 100.00% <100.00%> (ø)
include/mockturtle/io/blif_reader.hpp 94.26% <0.00%> (+0.24%) :arrow_up:
include/mockturtle/algorithms/cut_enumeration.hpp 81.81% <0.00%> (+0.27%) :arrow_up:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Nov 09 '22 10:11 codecov-commenter

Thank you for the contribution. A few things:

  • Updates to lorina should be made in the source repository first. It would also be great to provide a test case there to justify your fix.
  • Changes to network interfaces should be documented.
  • Would also be nice to have a test to ensure correctness of sequential cuts.

lee30sonia avatar Nov 09 '22 13:11 lee30sonia

Todos (ready to merge if all boxes below are checked)

  • [x] remove unnecessary modifications
  • [x] update changes to the interface in the documentation
  • [x] add test cases for sequential k-LUT mapping

Nozidoali avatar Dec 12 '22 14:12 Nozidoali

Thanks!

lee30sonia avatar Dec 13 '22 17:12 lee30sonia