Kyle Van Essen

Results 27 comments of Kyle Van Essen

I'm good with this, but last time we did this (I think in Blueprint?) it caused _massive_ pain for integrating longer running PRs because it basically multiplied conflicts a ton,...

You should be able to push new content in when the width of your containing view changes I think

Moved CacheTree changes to a new PR: https://github.com/square/Blueprint/pull/362

Ran the Register snapshot tests over this again, and there's a bunch of tiny lil 1px rounding changes, but I only found a couple meaningful differences, which seem to be...

Still seeing a ~40% bump with the optimization, despite removing the caching optimization: ``` Iterations: 5, Average Time: 0.45009841918945315 Iterations: 9, Average Time: 0.24431955814361572 ```

Hey @kylebshr @n8chur @watt thoughts on this? Lets us add coordinate space reading to any arbitrary element; which is useful for, eg, `MarketButton` and still let people put it into...

> Should this be automatic? We could measure shrunk children and use the new measurement if it's smaller than the original. I think it's usually desired, but doing it automatically...

Based on doing some preliminary testing in Market, I think this PR https://github.com/square/Blueprint/pull/348 ends up resolving this issue somewhat, because the measurement now takes place in a much more realistic...

Closing, given that https://github.com/square/Blueprint/pull/348 addresses this for the most part

It doesn't, though – this is a valid, existing use case throughout both Market, and SPOS – people need to measure content that lives in a nested view, usually a...