ksew1
ksew1
> I've Dropped some minor comments, but LGMT. There are some part that are common for all of NB algorithms. I think that it will be cool to separate them...
> Any reason why `num_categories` isn't a required option? `num_categories` isn’t needed as an option since it’s just an implementation detail. We can easily calculate it from `min_categories`, which the...
> Hi, @ksew1, thanks for contributing! I have some questions: > > * Why does Scarb need this function for the backtrace feature? > > * How does this feature...
> @ksew1 I think this PR looks good but you need to sign your commits to get the CI working. Should be signed now
@dependabot rebase
@dependabot rebase
> ## Explorer service > > I have hardcoded two links (StarkScan and Voyager), but actual implementation uses StarkScan only. How should I introduce some customisation to it? I think...
This currently blocked by `starknet-rs`. If this is urgent as part of the task you must update `ArgentAccountFactory` to support new format of `call_data`